Use names that will still make sense in six months. If business terminology changes often, agree on a controlled naming approach so formulas and reports stay readable.
Some dimensions need a flat list. Others need a parent-child structure so values can roll up into a total. Choose the simplest structure that still supports reporting.